Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run fireteam sync PREH after apex #424

Merged
merged 1 commit into from
Jul 12, 2016
Merged

Conversation

PabstMirror
Copy link
Contributor

Tag @BaerMitUmlaut

APEX changelog:

Added: Multiplayer synchronization for assigned team functionality

We shouldn't need the PFEH running to sync.
It will still run on linux versions before 1.62.

ACE used the CBA_teamColorChanged event and I see no reason to remove it as other might have as well.

@BaerMitUmlaut
Copy link
Contributor

👍

@commy2
Copy link
Contributor

commy2 commented Jul 12, 2016

Is it confirmed that the vanilla thing works?

@nicolasbadano
Copy link
Contributor

Added: Multiplayer synchronization for assigned team functionality

Yay! And it only took them a decade or so

@commy2 commy2 added this to the 3.0 milestone Jul 12, 2016
@commy2
Copy link
Contributor

commy2 commented Jul 12, 2016

I can confirm that this works since v1.62

See note: https://community.bistudio.com/wiki/assignTeam

@commy2 commy2 self-assigned this Jul 12, 2016
@commy2 commy2 merged commit 66a7ddf into master Jul 12, 2016
@commy2 commy2 deleted the cleanupFireteamSync branch July 12, 2016 16:23
@Killswitch00 Killswitch00 modified the milestones: 2.5.1, 3.0 Jul 12, 2016
@@ -19,6 +19,9 @@ Author:
params ["_unit", "_team"];

_unit assignTeam _team;

if ((productVersion select 2) > 162) exitWith {};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be >=?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed by #430

@Killswitch00 Killswitch00 modified the milestones: 3.0, 2.5.1 Jul 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants